Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't assign missions during testing, for real this time #78649

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Don't assign missions during testing, for real this time #78649

merged 1 commit into from
Dec 19, 2024

Conversation

RenechCDDA
Copy link
Member

Summary

None

Purpose of change

Followup to #78614....

I overwrote the wrong EOCs.

Describe the solution

Shamefully open this PR, overwriting the correct ones this time.

Also remove the redundant EOCs from base game so I can't make this mistake in the future.

image

Describe alternatives you've considered

Testing

Green CI good CI

Additional context

This should not have any effect outside of the testing environment. Fingers crossed I haven't jinxed myself by saying that

@RenechCDDA RenechCDDA changed the title Kill test error, for real this time Don't assign missions during testing, for real this time Dec 18, 2024
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Missions Quests and missions Code: Tests Measurement, self-control, statistics, balancing. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 18, 2024
@Maleclypse Maleclypse merged commit 53fb1e9 into CleverRaven:master Dec 19, 2024
24 of 29 checks passed
@RenechCDDA RenechCDDA deleted the kill_test_error_2 branch December 19, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tests Measurement, self-control, statistics, balancing. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Missions Quests and missions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RenechCDDA @Maleclypse